[PATCH] D133695: [InstCombine] Optimize multiplication where both operands are negated
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 13 08:25:09 PDT 2022
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, with an additional nit. Let's wait a bit with landing in case there are any further comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1833
+ case Intrinsic::matrix_multiply: {
+ // remove negation operation when both operands are negated in matrix
+ // multiplication -A * -B = A * B
----------------
nit: comment should be full sentences: capitalize first letter, end with period.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133695/new/
https://reviews.llvm.org/D133695
More information about the llvm-commits
mailing list