[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D125784#3782038 <https://reviews.llvm.org/D125784#3782038>, @djtodoro wrote:

> LGTM, thanks

@djtodoro Thanks for your reviews.



================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp:138
 
+uint32_t LVElement::getAccessibilityCode(MemberAccess Access) {
+  switch (Access) {
----------------
djtodoro wrote:
> `optional` instead of returning `0`? 
Changed to `Optional`.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp:185
 
+uint32_t LVElement::getVirtualityCode(MethodKind Virtuality) {
+  switch (Virtuality) {
----------------
djtodoro wrote:
> the same as above
Changed to `Optional`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784