[PATCH] D131930: [mlgo] Add in-development instruction based features for regalloc advisor

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman marked 10 inline comments as done.
aidengrossman added inline comments.


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:286
+struct LRStartEndInfo {
+  SlotIndex Begin;
+  SlotIndex End;
----------------
mtrofin wrote:
> Initialize things that don't have default ctors easy to do at def, and avoids nondeterministic bugs. Like Pos, at minimum, set it to 0.
That's a good point. Done for `Pos`. The `SlotIndex` class has a default constructor creating an invalid index, so we should be good there.


================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:288
+  SlotIndex End;
+  size_t Pos;
+};
----------------
mtrofin wrote:
> add a comment as to what `Pos` is - it's the index of the column corresponding to the physical register of the live interval segment captured by this LRStartEndInfo, right? (or the candidate)
> 
> also a comment for LRStartEndInfo overall
> 
> 
Added a comment for the entirety of `LRStartEndInfo` which also covers the meaning of the `Pos` member.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131930/new/

https://reviews.llvm.org/D131930