[PATCH] D133751: [llvm-objdump] Change printSymbolVersionDependency to use ELFFile API

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: jhenderson, raj.khem.
Herald added subscribers: StephenFan, rupprecht, emaste.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When .gnu.version_r is empty (allowed by readelf but warned by objdump),
llvm-objdump -p may decode the next section as .gnu.version_r and may crash due
to out-of-bounds C string reference. ELFFile<ELFT>::getVersionDependencies
handles 0-entry .gnu.version_r gracefully. Just use it.

Fix https://github.com/llvm/llvm-project/issues/57707


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133751

Files:
  llvm/include/llvm/Object/ELF.h
  llvm/test/tools/llvm-objdump/ELF/verneed-invalid.test
  llvm/test/tools/llvm-objdump/ELF/verneed.test
  llvm/tools/llvm-objdump/ELFDump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133751.459662.patch
Type: text/x-patch
Size: 4765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220913/5af66e88/attachment.bin>