[PATCH] D133747: Address feedback in https://reviews.llvm.org/D133637

[YongKang Zhu via Phabricator via llvm-commits]

yozhu created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
yozhu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

https://reviews.llvm.org/D133637 fixes the problem where we should the raw content of register
mask instead of the pointer to it.

Fix the same issue in `llvm::hash_value()`.

Remove the newly added API `MachineOperand::getRegMaskSize()` to avoid poential confusion.

Keep the fallback logic in the original change but add an assert to emphasize that we probably
should hash an machine operand iff it has associated machine function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133747

Files:
  llvm/include/llvm/CodeGen/MachineOperand.h
  llvm/lib/CodeGen/MachineOperand.cpp
  llvm/lib/CodeGen/MachineStableHash.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133747.459649.patch
Type: text/x-patch
Size: 5436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220913/f8d30aa4/attachment.bin>