[PATCH] D64833: [Xtensa 7/10] Add Xtensa instruction printer.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp:89
+    int64_t Value = MI->getOperand(OpNum).getImm();
+    assert((Value >= -128 && Value <= 127) &&
+           "Invalid argument, value must be in ranges [-128,127]");
----------------
`isInt<8>` from MathExtras.h


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp:93
+  } else
+    printOperand(MI, OpNum, O);
+}
----------------
Add braces. `then` uses braces and `else` should use, too.


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp:100
+    int64_t Value = MI->getOperand(OpNum).getImm();
+    assert((Value >= -32768 && Value <= 32512 && ((Value & 0xFF) == 0)) &&
+           "Invalid argument, value must be multiples of 256 in range "
----------------
isInt<16> from MathExtras.h


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64833/new/

https://reviews.llvm.org/D64833