[PATCH] D133745: [ELF] Relocations: amends c8d9d0000b2f72b50729bfdc7bbb9dd3e9ecd6a0

[Alfredo Dal'Ava Júnior via Phabricator via llvm-commits]

adalava created this revision.
adalava added reviewers: nemanjai, MaskRay.
Herald added subscribers: StephenFan, krytarowski, arichardson, emaste.
Herald added a project: All.
adalava published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

It's expected to set set hasDirectReloc only if not ifunc.

This fixes the issue described in https://reviews.freebsd.org/D36234


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133745

Files:
  lld/ELF/Relocations.cpp


Index: lld/ELF/Relocations.cpp
===================================================================
--- lld/ELF/Relocations.cpp
+++ lld/ELF/Relocations.cpp
@@ -1442,7 +1442,7 @@
     }
   } else if (needsPlt(expr)) {
     sym.setFlags(NEEDS_PLT);
-  } else if (LLVM_UNLIKELY(isIfunc)) {
+  } else if (LLVM_UNLIKELY(!isIfunc)) {
     sym.setFlags(HAS_DIRECT_RELOC);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133745.459635.patch
Type: text/x-patch
Size: 371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220913/19df8b13/attachment.bin>