[PATCH] D133637: Bug fix on stable hash calculation for machine operands RegisterMask and RegisterLiveOut

YongKang Zhu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 19:51:00 PDT 2022


yozhu added a comment.

Discussed with @MatzeB and @kyulee offline, and we will put up a new diff to remove the new API (so to get rid of confusion) and to duplicate the code in the few places where we need to hash MO.  For the concern that MO will have different hash values between when it has an associated MF and when it not, we will add an assert (suggesting that in most cases, if not all, we shouldn't hash MO if it doesn't belong to a MF) but will leave the fallback code as in the current change (for Release build, in case it is a valid scenario somewhere but not covered by the current set of tests).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133637/new/

https://reviews.llvm.org/D133637



More information about the llvm-commits mailing list