[PATCH] D133740: [ELF][Distributed ThinLTO] Do not generate empty index when bitcode object is linked

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 18:04:34 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/LTO.cpp:293
 static void thinLTOCreateEmptyIndexFiles() {
+  StringSet<> linkedBitCodeFiles;
+  for (BitcodeFile *f : ctx->bitcodeFiles)
----------------
`DenseMap<StringRef>`


================
Comment at: lld/test/ELF/lto/thinlto-index-only.ll:51
+
+;; Ensure when the same bitcode object is given as both lazy and non-lazy,
+;; LLD does not generate an empty index for the lazy object.
----------------
Don't repeat the comments. You can place the RUN lines immediately after the last block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133740/new/

https://reviews.llvm.org/D133740



More information about the llvm-commits mailing list