[PATCH] D133728: [lld-macho][nfci] Don't include null terminator in StringRefs

[Roger Kim via Phabricator via llvm-commits]

Roger accepted this revision.
Roger added a comment.

Generally looks good :)



================
Comment at: lld/MachO/SyntheticSections.cpp:1546
       StringRef string = isec->getStringRef(i);
       memcpy(buf + isec->pieces[i].outSecOff, string.data(), string.size());
     }
----------------
It looks to me that we used to copy over a null terminator here but we no longer will do that. Am I correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133728/new/

https://reviews.llvm.org/D133728