[PATCH] D133604: [gn build] port a3172df59c32 (check-lldb)

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/utils/gn/secondary/lldb/test/BUILD.gn:139
+  script = "//llvm/utils/gn/build/write_file.py"
+  outputs = [
+    "$root_out_dir/obj/lldb/test/Shell/lit-lldb-init-quiet"
----------------
If you `llvm/utils/gn/gn.py format llvm/utils/gn/secondary/lldb/test/BUILD.gn`, it'll probably put this on a single line. (But whatever gn's formatter output is correct.)


================
Comment at: llvm/utils/gn/secondary/lldb/test/BUILD.gn:143
+  args = [
+    rebase_path(outputs[0]),
+    "command source -C --silent-run true lit-lldb-init"
----------------
Pass `root_build_dir` as second arg, then GN will write a relative path in the generated ninja file. As-is works too, but then it writes an absolute path. It's nice if the generated ninja files are machine-independent. (i.e. replace this line with `rebase_path(outputs[0], root_build_dir),`)


================
Comment at: llvm/utils/gn/secondary/lldb/test/BUILD.gn:153
   deps = [
     ":lit-lldb-init",
     ":lit_api_site_cfg",
----------------
Please keep alphabetized, put new dep here. (`gn format` should fix this for you.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133604/new/

https://reviews.llvm.org/D133604