[PATCH] D133582: [ASan] rename internal references to left of/right of.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 14:14:33 PDT 2022


fmayer marked an inline comment as done.
fmayer added a comment.

PTAL. I'd like to merge this earlier rather than later if possible, to avoid merge conflicts.



================
Comment at: compiler-rt/lib/asan/asan_allocator.cpp:75
 //   U -- user memory.
-//   R -- right redzone (0 or more bytes)
+//   B -- back redzone (0 or more bytes)
 // ChunkBase consists of ChunkHeader and other bytes that overlap with user
----------------
eugenis wrote:
> I don't get this. Why P and S vs F and B?
if you were referring to the below, that was a mistake (it used to be preceding / succeeding but i think front / back is better. happy to revert back to that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133582/new/

https://reviews.llvm.org/D133582



More information about the llvm-commits mailing list