[PATCH] D132663: [NVPTX] Use MBB.begin() instead MBB.front() in NVPTXFrameLowering::emitPrologue

Mon Sep 12 11:39:35 PDT 2022

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM with a test nit.

================
Comment at: llvm/test/CodeGen/NVPTX/bug52623.ll:9
+
+; CHECK-LABEL: __kmpc_get_hardware_thread_id_in_block
+define internal i32 @__kmpc_get_hardware_thread_id_in_block(i1 %0) {
----------------
Considering that there are no meaningful CHECK lines in the test, it may be worth adding a comment describing what it is that we're testing for here. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132663/new/

https://reviews.llvm.org/D132663