[PATCH] D129385: [lsan][Darwin] Scan libdispatch and Foundation memory regions

[Leonard Grey via Phabricator via llvm-commits]

lgrey added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_common_mac.cpp:36
+struct RegionScanState {
+  int seen_regions = static_cast<int>(SeenRegion::None);
+  bool in_libdispatch = false;
----------------
yln wrote:
> Would making this a `SeenRegion` field get rid of the casts?
Only if we implement `operator|` on it and do the casts in there. Given the number of uses it seems like a wash to me, happy to go with whichever you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129385/new/

https://reviews.llvm.org/D129385