[PATCH] D133480: [llvm-dwp] Get the DWO file from relative path if the absolute path is not valid

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds OK - some minor test case improvements that might be useful.



================
Comment at: llvm/test/tools/llvm-dwp/X86/search_dwos.test:12
+
+clang++ -Xclang -fdebug-compilation-dir -Xclang "/tmp" -g -O0 -gsplit-dwarf a.cpp b.cpp -o main
+
----------------
maybe use a less-likely-to-accidentally-exist path rather than `/tmp` (`/non-existent` or something?) (& any ideas how this works if the test runs on Windows? does the absolute path confuse things? maybe using a relative comp-dir like `non-existent` (without the leading `/`) would be better? Not sure how the other tests work already


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133480/new/

https://reviews.llvm.org/D133480