[PATCH] D133706: ControlHeightReduction: Remove assert check in shouldApply

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

I keep hitting this assertion when using LTO+PGO with an assertion enabled LLVM/clang build for the llvm-test-suite. While I haven't debugged this to the end, I suspect there is some oddities in the llvm-test-suite build not passing the ThinLTO or PGO parameters down properly to the google-benchmark files in there and ThinLTO choosing a partition where none of the functions has profile info.

While this is a somewhat badly setup build it should not hit an assertion in the compiler, can we drop this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133706/new/

https://reviews.llvm.org/D133706