[PATCH] D133606: [AMDGPU][MC] Add detection of mandatory literals in parser

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp updated this revision to Diff 459466.
dp retitled this revision from "[AMDGPU][MC] Add detection of hardcoded literals in parser" to "[AMDGPU][MC] Add detection of mandatory literals in parser".
dp edited the summary of this revision.
dp added a comment.

Thanks for your valuable comments! I corrected the wording and replaced "hardcoded" with "mandatory".

> Is it possible to add a test with this? Something like assembling a VOPD with multiple literals and getting an error like "error: only one literal operand is allowed"? Or does that still require more functionality?

I do not think it is possible to test these changes without adding more functionality. If you prefer, I could merge this change with the next one which validates use of literals.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133606/new/

https://reviews.llvm.org/D133606

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133606.459466.patch
Type: text/x-patch
Size: 4635 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220912/8be3a168/attachment.bin>