[PATCH] D129385: [lsan][Darwin] Scan libdispatch and Foundation memory regions

[Leonard Grey via Phabricator via llvm-commits]

lgrey added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_common_mac.cpp:41
 
+enum SeenRegion {
+  kNone = 0,
----------------
yln wrote:
> Slight preference to make this an enum class and drop the `k` prefix:
> 
> ```
> enum class RegionKind {
>   None = 0,
> ....
> 
> scan_state.seen_regions |= RegionKind::AllocOnce;
> 
> ```
> 
> 
Done (but a little uglier now since it needs casts if that makes a difference).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129385/new/

https://reviews.llvm.org/D129385