[PATCH] D133666: pVplan] Add VPValue::isDefinedOutsideVectorRegions helper (NFC).

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 08:07:20 PDT 2022


reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:3058
       return Rep->isUniform();
-    return false;
+    return VPV->isDefinedOutsideVectorRegions();
   }
----------------
With this placement, this is equivalent to return false.  The interesting case is the return true below.

Maybe:

```
if (VPV->isDefinedOutsideVectorRegion())
  return true;
auto *Def = VPV->getDef();
assert(Def);  
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133666/new/

https://reviews.llvm.org/D133666



More information about the llvm-commits mailing list