[PATCH] D133482: [LLVM] Fix GetErrcMessages.cmake module for WoA

[Markus Böck via Phabricator via llvm-commits]

zero9178 accepted this revision.
zero9178 added a comment.
This revision is now accepted and ready to land.

LGTM % nit. Thanks!



================
Comment at: llvm/CMakeLists.txt:109
+# Set default build type for cmake's try_compile module.
+if(CMAKE_DEFAULT_BUILD_TYPE)
+  set(CMAKE_TRY_COMPILE_CONFIGURATION ${CMAKE_DEFAULT_BUILD_TYPE})
----------------
nit: I think it might be great to add a comment that once LLVM uses cmake 3.17 as minimum, the code can be simplified to just always use `CMAKE_DEFAULT_BUILD_TYPE` in the `CMAKE_CONFIGURATION_TYPES` case (since that gets initialized with the first element in `CMAKE_CONFIGURATION_TYPES`). Until then I like this approach of already using it if a user were to define it, even prior to 3.17. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133482/new/

https://reviews.llvm.org/D133482