[PATCH] D133610: [RegisterCoalescer] Use LiveRangeEdit to handle rematerialization

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 05:57:27 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:197
+  if (ReplaceIndexMI)
+    return LIS.ReplaceMachineInstrInMaps(*ReplaceIndexMI, *MI);
   return LIS.getSlotIndexes()->insertMachineInstrInMaps(*MI, Late).getRegSlot();
----------------
Shouldn't this return getRegSlot like the fallthrough case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133610/new/

https://reviews.llvm.org/D133610



More information about the llvm-commits mailing list