[PATCH] D133476: [automation] Add scripts to automate GitHub projects

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 05:48:11 PDT 2022


thieta added a comment.

In D133476#3783340 <https://reviews.llvm.org/D133476#3783340>, @kwk wrote:

> @thieta as much as I like the effort you've made here. I'd like to propose a standalone GraphQL library. You're adding lots of code that is hard to trust without tests. That is why I started to create a library with tests and a release process to pypi. I think much of the things you do here are so generic that we can integrate them into the library at will.

Hi,

No problem - I was actually not that keen on adding all that code, but the only python graphql library I found was graphene and it seemed to be insane overkill. I learned a lot about GraphQL in the process so I don't mind moving it to another library.

> https://github.com/kwk/ghgql
>
> So far I will try to see if we can add the queries you've written nicely into "my" library.

Yeah I think the only complicated part of my script was to figure out the GraphQL queries and syntax, the code to request graphql's are pretty straightforward.

The only thing I would make sure we avoid is to make this to-complicated, graphql already seems very over-engineered (to my eyes) and we just need such a small small subset that we shouldn't put to much effort into handling all kinds of queries and edge-cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133476/new/

https://reviews.llvm.org/D133476



More information about the llvm-commits mailing list