[lld] c812b4a - [LLD] Fix pdb-natvis.test for Windows on Arm

Muhammad Omair Javaid via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 05:25:06 PDT 2022


Author: Muhammad Omair Javaid
Date: 2022-09-12T17:23:59+05:00
New Revision: c812b4a1d8956868a91f02ab86a926607c5e005c

URL: https://github.com/llvm/llvm-project/commit/c812b4a1d8956868a91f02ab86a926607c5e005c
DIFF: https://github.com/llvm/llvm-project/commit/c812b4a1d8956868a91f02ab86a926607c5e005c.diff

LOG: [LLD] Fix pdb-natvis.test for Windows on Arm

pdb-natvis test fails on Arm Windows as generated byte sizes and crc
differ for Windows on Arm. This patch fixes the test to make it pass on
Arm/Windows.

Added: 
    

Modified: 
    lld/test/COFF/pdb-natvis.test

Removed: 
    


################################################################################
diff  --git a/lld/test/COFF/pdb-natvis.test b/lld/test/COFF/pdb-natvis.test
index 15cff5011ef2b..b136ba62bd371 100644
--- a/lld/test/COFF/pdb-natvis.test
+++ b/lld/test/COFF/pdb-natvis.test
@@ -14,13 +14,13 @@ RUN:   --check-prefix=CHECK-THIRD %s
 RUN: lld-link /DEBUG %t.obj /nodefaultlib /entry:main /NATVIS:%p/Inputs/test2.natvis \
 RUN:   /OUT:%t.exe /PDB:%t.pdb 2>&1 | FileCheck --check-prefix=CHECK-MISSING %s
 
-CHECK-FIRST:      {{.*}}natvis-1.natvis (16 bytes): obj=<null>, vname={{.*}}natvis-1.natvis, crc=355285096, compression=None
+CHECK-FIRST:      {{.*}}natvis-1.natvis ({{16|17}} bytes): obj=<null>, vname={{.*}}natvis-1.natvis, crc={{355285096|3974675339}}, compression=None
 CHECK-FIRST-NEXT: 1st Natvis Test
 
-CHECK-SECOND:      {{.*}}natvis-2.natvis (19 bytes): obj=<null>, vname={{.*}}natvis-2.natvis, crc=4252640062, compression=None
+CHECK-SECOND:      {{.*}}natvis-2.natvis ({{19|20}} bytes): obj=<null>, vname={{.*}}natvis-2.natvis, crc={{4252640062|1846024273}}, compression=None
 CHECK-SECOND-NEXT: Second Natvis Test
 
-CHECK-THIRD:      {{.*}}natvis-3.natvis (18 bytes): obj=<null>, vname={{.*}}natvis-3.natvis, crc=2069719849, compression=None
+CHECK-THIRD:      {{.*}}natvis-3.natvis ({{18|19}} bytes): obj=<null>, vname={{.*}}natvis-3.natvis, crc={{2069719849|3982342878}}, compression=None
 CHECK-THIRD-NEXT: Third Natvis Test
 
 CHECK-MISSING: Cannot open input file: {{.*}}test2.natvis
\ No newline at end of file


        


More information about the llvm-commits mailing list