[PATCH] D133625: [mlir][MemRef] Simplify extract_strided_metadata(expand_shape)

[lorenzo chelini via Phabricator via llvm-commits]

chelini accepted this revision.
chelini added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:211
+    Value source = expandShape.getSrc();
+    auto sourceType = source.getType().cast<MemRefType>();
+    unsigned sourceRank = sourceType.getRank();
----------------



================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:231
+
+    // The result value will start with the base_buffer and offset.
+    unsigned baseIdxInResult = 2;
----------------
I would mention explicitly that this pattern does not affect base buffer and offset, as mentioned in the test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133625/new/

https://reviews.llvm.org/D133625