[PATCH] D133203: [TypePromotionPass] Don't treat phi's as ToPromote

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 01:36:49 PDT 2022


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

> I presume they were meant to be? I've added some other tests that were.

Oh, well... thanks!

> Best I have so far is to check if there are sinks inside the loops with sources outside.

Makes sense to me, and looks like it's doing the job.

LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133203/new/

https://reviews.llvm.org/D133203



More information about the llvm-commits mailing list