[PATCH] D133672: [GlobalISel] Fix crash when lowering G_SELECT of pointer vectors.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7272
   auto NewOp2 = MIRBuilder.buildAnd(MaskTy, Op2Reg, NotMask);
-  MIRBuilder.buildOr(DstReg, NewOp1, NewOp2);
+  if (!IsEltPtr)
+    MIRBuilder.buildOr(DstReg, NewOp1, NewOp2);
----------------
Nit: when there's an "else" I prefer to put the "if (IsEltPtr)" case first to avoid an implied double negative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133672/new/

https://reviews.llvm.org/D133672