[PATCH] D133672: [GlobalISel] Fix crash when lowering G_SELECT of pointer vectors.
Thorsten via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 11 12:00:52 PDT 2022
tschuett added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:7275
+ else {
+ auto Or = MIRBuilder.buildOr(DstTy, NewOp1, NewOp2);
+ MIRBuilder.buildIntToPtr(DstReg, Or);
----------------
Could you hoist the `buildOr` out of the if-statement? Then you only need the cast if `IsEltPtr`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133672/new/
https://reviews.llvm.org/D133672
More information about the llvm-commits
mailing list