[llvm] 44ffc13 - Make sure libLLVM users link with libatomic if needed

Aaron Puchert via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 11 11:45:50 PDT 2022


Author: Aaron Puchert
Date: 2022-09-11T20:44:53+02:00
New Revision: 44ffc13f2eb6188a86ae88ea1e942e9ac354db9b

URL: https://github.com/llvm/llvm-project/commit/44ffc13f2eb6188a86ae88ea1e942e9ac354db9b
DIFF: https://github.com/llvm/llvm-project/commit/44ffc13f2eb6188a86ae88ea1e942e9ac354db9b.diff

LOG: Make sure libLLVM users link with libatomic if needed

64-bit atomics are used in llvm/ADT/Statistic.h, which means that users
of libLLVM.so might also have to link with libatomic. To avoid having
to special-case the library here, we simply add all `LLVM_SYSTEM_LIBS`
as public link dependencies to libLLVM.

This fixes a build failure on PowerPC 32-bit.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D132799

Added: 
    

Modified: 
    llvm/tools/llvm-shlib/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-shlib/CMakeLists.txt b/llvm/tools/llvm-shlib/CMakeLists.txt
index 8e2b78f1b85c0..cc6713a79fcdc 100644
--- a/llvm/tools/llvm-shlib/CMakeLists.txt
+++ b/llvm/tools/llvm-shlib/CMakeLists.txt
@@ -63,6 +63,9 @@ if(LLVM_BUILD_LLVM_DYLIB)
 
   target_link_libraries(LLVM PRIVATE ${LIB_NAMES})
 
+  get_property(SYSTEM_LIBS TARGET LLVMSupport PROPERTY LLVM_SYSTEM_LIBS)
+  target_link_libraries(LLVM PUBLIC ${SYSTEM_LIBS})
+
   if (APPLE)
     set_property(TARGET LLVM APPEND_STRING PROPERTY
                 LINK_FLAGS


        


More information about the llvm-commits mailing list