[PATCH] D133567: [AA] Improve the BasicAA analysis capability

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:615
+        if (isa<ScalableVectorType>(GEPOp->getSourceElementType()) &&
+            (I - GEPOp->op_begin() != GEPOp->getNumOperands() - 1)) {
+          Decomposed.Base = V;
----------------
Instead of checking the source element type, this should check whether the getTypeAllocSize fetched below isScalable.


================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:624
         continue;
+      } else if (isa<ScalableVectorType>(GEPOp->getSourceElementType())) {
+        Decomposed.Base = V;
----------------
nit: Drop else after continue.


================
Comment at: llvm/test/Transforms/GVN/vscale.ll:49
 
 ; TODO: BasicAA return MayAlias for %gep1,%gep2, could improve as MustAlias.
 define i32 @load_clobber_load_gep1(<vscale x 4 x i32>* %p) {
----------------
Drop TODO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133567/new/

https://reviews.llvm.org/D133567