[PATCH] D133646: Add a utility for converting between different types of remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

Looks straightforward and pretty good to me. Thanks for working on this.

One suggestion would be to have a `convert` subcommand that takes `bitstream2yaml` or `yaml2bitstream`, assuming this tool will be extended to do more (for example, one thing I want to add is `extract` from a mach-o object file). I don't have strong opinions though so if everyone is fine with this I'm also fine.



================
Comment at: llvm/tools/llvm-remarkutil/RemarkUtil.cpp:49
+namespace yaml2bitstream {
+Format InputFormat = Format::YAML;
+Format OutputFormat = Format::Bitstream;
----------------
Does this need a `static`/`const`/`constexpr`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133646/new/

https://reviews.llvm.org/D133646