[PATCH] D133321: [Assignment Tracking][24/*] Always RemoveRedundantDbgInstrs in instcombine in assignment tracking builds

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 10 08:58:57 PDT 2022


chrisjackson added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:4353
     MadeIRChange = LowerDbgDeclare(F);
+  // LowerDbgDeclare calls RemoveRedundantDbgInstrs, but LowerDbgDeclare will
+  // almost never return true when running an assignment tracking build. Take
----------------
Possible suitable branch hint location, based on your comment?

I'm not sure they are in the llvm's c++ version though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133321/new/

https://reviews.llvm.org/D133321



More information about the llvm-commits mailing list