[PATCH] D133253: [SPIRV] add IR regularization pass

[Andrey Tretyakov via Phabricator via llvm-commits]

andreytr added a comment.

Suggest small style test fixes.



================
Comment at: llvm/test/CodeGen/SPIRV/lshr-constexpr.ll:5-11
+; CHECK-SPIRV: %[[#type_vec:]] = OpTypeVector %[[#type_int32]] 2
+; CHECK-SPIRV: %[[#const1:]] = OpConstant %[[#type_int32]] 1
+; CHECK-SPIRV: %[[#vec_const:]] = OpConstantComposite %[[#type_vec]] %[[#const1]] %[[#const1]]
+; CHECK-SPIRV: %[[#const32:]] = OpConstant %[[#type_int64]] 32 0
+
+; CHECK-SPIRV: %[[#bitcast_res:]] = OpBitcast %[[#type_int64]] %[[#vec_const]]
+; CHECK-SPIRV: %[[#shift_res:]] = OpShiftRightLogical %[[#type_int64]] %[[#bitcast_res]] %[[#const32]]
----------------



================
Comment at: llvm/test/CodeGen/SPIRV/opencl/get_global_id.ll:41-42
+;; Functions:
+; CHECK: OpFunction %[[#I64]] None %[[#FN]]
+; CHECK: %[[#DIM:]] = OpFunctionParameter %[[#I32]]
+
----------------



================
Comment at: llvm/test/CodeGen/SPIRV/opencl/get_global_id.ll:45-46
+;; get_global_id(0): OpLoad + OpCompositeExtract.
+; CHECK: %[[#TMP1:]] = OpLoad %[[#VEC]] %[[#GET_GLOBAL_ID]]
+; CHECK: %[[#X:]] = OpCompositeExtract %[[#I64]] %[[#TMP1]] 0
+
----------------



================
Comment at: llvm/test/CodeGen/SPIRV/opencl/get_global_id.ll:53
+; CHECK-DAG: %[[#COND:]] = OpULessThan %[[#BOOL]] %[[#DIM]] %[[#THREE]]
+; CHECK: %[[#UNKNOWN:]] = OpSelect %[[#I64]] %[[#COND]] %[[#TMP3]] %[[#ZERO]]
----------------



================
Comment at: llvm/test/CodeGen/SPIRV/transcoding/OpMin.ll:4
+; CHECK-SPIRV: %[[#SetInstID:]] = OpExtInstImport "OpenCL.std"
+; CHECK-SPIRV: %[[#IntTypeID:]] = OpTypeInt 32 {{[0-9]+}}
+; CHECK-SPIRV: %[[#Int2TypeID:]] = OpTypeVector %[[#IntTypeID]] 2
----------------



================
Comment at: llvm/test/CodeGen/SPIRV/transcoding/OpMin.ll:6-7
+; CHECK-SPIRV: %[[#Int2TypeID:]] = OpTypeVector %[[#IntTypeID]] 2
+; CHECK-SPIRV: %[[#CompositeID:]] = OpCompositeInsert %[[#Int2TypeID]] %[[#]] %[[#]] {{[0-9]+}}
+; CHECK-SPIRV: %[[#ShuffleID:]] = OpVectorShuffle %[[#Int2TypeID]] %[[#CompositeID]] %[[#]] {{[0-9]+}} {{[0-9]+}}
+; CHECK-SPIRV: %[[#]] = OpExtInst %[[#Int2TypeID]] %[[#SetInstID]] s_min %[[#]] %[[#ShuffleID]]
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133253/new/

https://reviews.llvm.org/D133253