[PATCH] D115757: [SLP]Generalize cost model.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5834
+      return false;
     return cast<Instruction>(V)->getOperand(OpIdx) == Op0;
   });
----------------
I->getOperand(OpIdx) == Op0;


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5840
+    if (!I)
+      return true;
     auto *Op = cast<Instruction>(V)->getOperand(OpIdx);
----------------
true?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5841
+      return true;
     auto *Op = cast<Instruction>(V)->getOperand(OpIdx);
     if (auto *CI = dyn_cast<ConstantInt>(Op))
----------------
auto *Op = I->getOperand(OpIdx);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115757/new/

https://reviews.llvm.org/D115757