[PATCH] D130466: [LICM] - Add option to allow data races

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 10 02:33:43 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2149
+    bool SafeToInsertStore =
+        (dyn_cast<GlobalVariable>(Object) && TTI->isSingleThreaded()) ||
+        ThreadModelSingle;
----------------
The check for GlobalVariable should go inside isWritableObject() and needs to check !isConstant().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130466/new/

https://reviews.llvm.org/D130466



More information about the llvm-commits mailing list