[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp:138
 
+uint32_t LVElement::getAccessibilityCode(MemberAccess Access) {
+  switch (Access) {
----------------
`optional` instead of returning `0`? 


================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp:185
 
+uint32_t LVElement::getVirtualityCode(MethodKind Virtuality) {
+  switch (Virtuality) {
----------------
the same as above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784