[PATCH] D133607: Improve ArchiveWriter diagnostics

[Yi Kong via Phabricator via llvm-commits]

kongyi added inline comments.


================
Comment at: llvm/test/Object/archive-malformed-object.test:13
 
-# ERR1: error: bad.a: Invalid bitcode signature
+# ERR1: error: bad.a: 'input.bc': Invalid bitcode signature
 
----------------
MaskRay wrote:
> Archive members are often described with `xxx(yyy)` syntax, i.e. 
> 
> `# ERR1: error: bad.a(input.bc): Invalid bitcode signature`
These are added at different points. Rustc uses the ArchiveWriter API, it only gets the member part. If we switch to your suggested syntax, the printout from Rustc would become

`error: failed to build archive: ('fake_bt_keystore.o') Not an int attribute (Producer: 'LLVM15.0.1git' Reader: 'LLVM 14.0.5-rust-dev')`



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133607/new/

https://reviews.llvm.org/D133607