[PATCH] D133604: [gn build] port a3172df59c32 (check-lldb)

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!

`write_file` runs at gn time. Is it possible to instead make an action that writes this as a build step, and then make `check-lldb` depend on that?

It's a bit more involved: You have to create a python script that writes the output (since `action()`s always run python scripts). llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn has an example of an action(), I can help you if you get stuck. (`llvm/utils/gn/gn.py help action` has some notes too.)

On one hand, `write_file` is pretty fast. On the other hand, we currently don't need to do any work like this at GN time in LLVM's gn build, and it'd be nice if it stayed that way. (People who don't build `check-lldb` don't need this file, so it's wasted work.)

And just FYI, iirc `check-lldb` in the GN build only runs a subset of the tests that run in the CMake build. (Maybe only the lit-based ones? Maybe those are called "API" tests?)

Thanks again for working on unbreaking `check-lldb` in the GN build :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133604/new/

https://reviews.llvm.org/D133604