[PATCH] D133616: [MLGO] ML Regalloc Priority Advisor

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 18:57:47 PDT 2022


mtrofin added a comment.

I think we need to separate in a first patch the changes needed to reuse regallocscoring. For those, I think maybe a simple solution right now would be to have the base `RegAllocEvictionAdvisorAnalysis` and `RegAllocPriorityAdvisorAnalysis` (the base types) have a `virtual void logRewardIfNeeded(float Reward)` method. By default it does nothing. Just the Development variant does something. So that way you don't need the additional .h for the scoring, just moving it to a .cpp would be sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133616/new/

https://reviews.llvm.org/D133616



More information about the llvm-commits mailing list