[PATCH] D132513: [lit] Implement DEFINE and REDEFINE directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:1270-1272
+        # '\' is documented as indicating a line continuation even if whitespace
+        # separates it from the newline.  It looks like a line continuation, and
+        # it would be confusing if it didn't behave as one.
----------------
jdenny wrote:
> jhenderson wrote:
> > How come this only applies to substitutions and not commands?
> `_handleCommand` already does the rstrip, so the effect is the same.  Would it help if I moved that logic into `CommandDirective`?
This comment was originally on the python documentation in `SubstDirective.needs_continuation`.

I've now addressed it by moving the `rstrip` call from `_handleCommand` to `CommandDirective` so that handling of whitespace stripping is consistently enscapsulated in the `SubstDirective` and `CommandDirective` classes.  I've moved the python documentation to the parent class's `needs_continuation`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132513/new/

https://reviews.llvm.org/D132513