[PATCH] D133607: Improve ArchiveWriter diagnostics

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> error: failed to build archive: 'fake_bt_keystore.o': Not an int attribute (Producer: 'LLVM15.0.1git' Reader: 'LLVM 14.0.5-rust-dev')

No existing test uses this diagnostic. Do we need more coverage? Personally I think `build archive:` can be `build archive` (i.e. remove one colon).



================
Comment at: llvm/test/Object/archive-malformed-object.test:13
 
-# ERR1: error: bad.a: Invalid bitcode signature
+# ERR1: error: bad.a: 'input.bc': Invalid bitcode signature
 
----------------
Archive members are often described with `xxx(yyy)` syntax, i.e. 

`# ERR1: error: bad.a(input.bc): Invalid bitcode signature`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133607/new/

https://reviews.llvm.org/D133607