[PATCH] D133003: [ELF] Parallelize relocation scanning

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:1543
+  // Deterministic parallellism needs sorting relocations which is unsuitable
+  // for -z nocombreloc. AndroidPackedRelocationSection does not support
+  // parallelism. MIPS and PPC64 use global states which are not suitable for
----------------
I'll remove `AndroidPackedRelocationSection does not support parallelism. `. It works with deterministic parallelism.


================
Comment at: lld/ELF/Relocations.cpp:1559
+    };
+    if (serial)
+      fn();
----------------
andrewng wrote:
> I wonder if it might be worthwhile using the previous code for the serial case? Although, it probably doesn't make a big difference to performance.
Use which piece of code for the serial case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133003/new/

https://reviews.llvm.org/D133003