[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D131960#3781458 <https://reviews.llvm.org/D131960#3781458>, @jamieschmeiser wrote:

> @aeubanks An interesting idea.  I'll give it some thought... it should be doable by combining this with the logic in the change printers but I'd be concerned that the detection of the changes would become a hotspot itself.  Perhaps a double run, the first to determine which passes make changes and then a recompile to time those passes that are then known to make changes.

Ideally we'd have some sort of hashing mechanism to hash functions rather than relying on printing the IR. But printing seems like a fine first step.
If we can augment the time trace to have some way to mark the last data point with some flag, we can stop the timer, determine if IR changed, then mark the data point accordingly and we shouldn't need two runs. Two runs seems like too much hassle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131960/new/

https://reviews.llvm.org/D131960