[PATCH] D133452: [ORC] Fix auto-claim of weak defs in ObjectLinkingLayer

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld added a comment.

@lhames I'm running `lli` with the LLVM IR emitted by Clang for something like

  int main() {
    try {
      throw 1;
    } catch (...) { }
    return 0;
  }



> 4dc110a4b83c625502092b127ca0e9eb13824297 <https://reviews.llvm.org/rG4dc110a4b83c625502092b127ca0e9eb13824297> caused us to claim responsibility for weak symbols that survived dead stripping. To trigger the issue that you're seeing I guess that we need to have a symbol that's (a) inserted late in the compiler pipeline, (b) unreferenced in the file that defines it, and (c) used elsewhere. Does that match what you're seeing?

Yes, I've mentioned that commit in my previous comment. I argue that the change in there never worked, and nobody noticed because it's seemingly not needed for x86.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133452/new/

https://reviews.llvm.org/D133452