[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 9 12:28:53 PDT 2022
aeubanks accepted this revision.
aeubanks added a comment.
nice cleanup, one nit
================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1176
+ },
+ true);
+ PIC.registerAfterPassInvalidatedCallback(
----------------
I'd rename the param to `InsertAtFront` and here it should be `/*InsertAtFront=*/ true`. We do this for params where we pass constants to make it harder to mess up if we add more bool params in the future, and just for reading clarity.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131960/new/
https://reviews.llvm.org/D131960
More information about the llvm-commits
mailing list