[PATCH] D129406: [ELF] Support ELFCOMPRESS_ZSTD input

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 12:16:16 PDT 2022


dblaikie added a comment.

In D129406#3780896 <https://reviews.llvm.org/D129406#3780896>, @MaskRay wrote:

> In D129406#3780891 <https://reviews.llvm.org/D129406#3780891>, @dblaikie wrote:
>
>> Looks like this didn't get reviewed?
>
> Happy to address changes if @ikudrin or @peter.smith has any suggestion.
> The changes are pretty mechanical and a dependent was accepted.

The LLVM review process is that if something's sent for review it should not be committed until that review is completed ( https://llvm.org/docs/CodeReview.html#code-review-workflow "Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed. Do not assume silent approval, or solicit objections to a patch with a deadline." ) . (we don't want to encourage people to send things for review that they believe needs review, then commit due to lack of feedback in the time they'd like to receive it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129406/new/

https://reviews.llvm.org/D129406



More information about the llvm-commits mailing list