[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navid Emamdoost via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 11:59:10 PDT 2022


Navidem marked an inline comment as done and an inline comment as not done.
Navidem added inline comments.


================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:807
         << "-fsanitize-coverage=[func|bb|edge]"
-        << "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc]";
+        << "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc|control-flow]";
   }
----------------
vitalybuka wrote:
> shouldn't this be:
> ,[trace-pc-guard|trace-pc],[control-flow]
> 
> probably even:
> [,(trace-pc-guard|trace-pc)][,control-flow]
> shouldn't this be:
> ,[trace-pc-guard|trace-pc],[control-flow]
> 
> probably even:
> [,(trace-pc-guard|trace-pc)][,control-flow]




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133157/new/

https://reviews.llvm.org/D133157



More information about the llvm-commits mailing list