[PATCH] D131959: [AMDGPU] Fix SDST operand of V_DIV_SCALE to always be VCC

Fri Sep 9 11:16:14 PDT 2022

jrbyrnes added a comment.

> + @jrbyrnes who did some work on implicit vs explicit uses of `$scc` in D128681 <https://reviews.llvm.org/D128681>.

Haven't looked fully into this review, but the work in D128681 <https://reviews.llvm.org/D128681> seems orthogonal to the issue here -- the issue in that ticket was involving not honoring live ranges. Glued copy nodes that wrote to a PhysReg didn't check if the copy would clobber a live range.

Anyway, are the vcc COPYs needed here? Maybe I don't understand something, but it would be nice to see isel not emit the COPY and just rely on the implicit def/use of $vcc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131959/new/

https://reviews.llvm.org/D131959