[PATCH] D124491: OpenMP: mark allocptr attribute on __kmpc_free_shared

Augie Fackler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 11:10:18 PDT 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fea8ee540aa: OpenMP: mark allocptr attribute on __kmpc_free_shared (authored by durin42).

Changed prior to commit:
  https://reviews.llvm.org/D124491?vs=444058&id=459136#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124491/new/

https://reviews.llvm.org/D124491

Files:
  llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
  llvm/test/Transforms/OpenMP/remove_globalization.ll


Index: llvm/test/Transforms/OpenMP/remove_globalization.ll
===================================================================
--- llvm/test/Transforms/OpenMP/remove_globalization.ll
+++ llvm/test/Transforms/OpenMP/remove_globalization.ll
@@ -155,7 +155,7 @@
 ; CHECK: declare i8* @__kmpc_alloc_shared(i64)
 declare i8* @__kmpc_alloc_shared(i64)
 
-; CHECK: declare void @__kmpc_free_shared(i8* nocapture, i64)
+; CHECK: declare void @__kmpc_free_shared(i8* allocptr nocapture, i64)
 declare void @__kmpc_free_shared(i8*, i64)
 
 declare void @unknown_no_openmp() "llvm.assume"="omp_no_openmp"
Index: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
===================================================================
--- llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
+++ llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
@@ -535,11 +535,6 @@
                                    EnumAttr(WillReturn), EnumAttr(NoFree))
                     : AttributeSet(EnumAttr(NoUnwind)))
 
-__OMP_ATTRS_SET(NoCaptureAttrs,
-                OptimisticAttributes
-                    ? AttributeSet(EnumAttr(NoCapture))
-                    : AttributeSet(EnumAttr(NoCapture)))
-
 __OMP_ATTRS_SET(AlwaysInlineAttrs,
                 OptimisticAttributes
                     ? AttributeSet(EnumAttr(AlwaysInline))
@@ -925,7 +920,7 @@
   EnumAttr(NoSync),
   AllocSizeAttr(0, None)), ReturnPtrAttrs, ParamAttrs())
 __OMP_RTL_ATTRS(__kmpc_free_shared, DeviceAllocAttrs, AttributeSet(),
-                ParamAttrs(NoCaptureAttrs))
+                ParamAttrs(AttributeSet(EnumAttr(NoCapture), EnumAttr(AllocatedPointer))))
 
 __OMP_RTL_ATTRS(__kmpc_alloc, DefaultAttrs, ReturnPtrAttrs, ParamAttrs())
 __OMP_RTL_ATTRS(__kmpc_aligned_alloc, DefaultAttrs, ReturnPtrAttrs,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124491.459136.patch
Type: text/x-patch
Size: 1749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220909/408dcd73/attachment.bin>


More information about the llvm-commits mailing list