[compiler-rt] d1fe5cf - [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior

Blue Gaston via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 08:54:40 PDT 2022


Author: Blue Gaston
Date: 2022-09-09T08:54:13-07:00
New Revision: d1fe5cf5224ee1ee0498533f5a299e3b49bcde45

URL: https://github.com/llvm/llvm-project/commit/d1fe5cf5224ee1ee0498533f5a299e3b49bcde45
DIFF: https://github.com/llvm/llvm-project/commit/d1fe5cf5224ee1ee0498533f5a299e3b49bcde45.diff

LOG: [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior

Reverting a patch that was added to test for getpwnam(NULL) -- it was noted at the time the behavior might have been a bug, however the patch was added for binary compatibility. Because of the change in the expected behavior, we are reverting this commit, as the test added is no longer passing.

Update: Rather than reverting the original commit, updating this to only remove the unnecessary test.

Original Patch: https://reviews.llvm.org/D40052

rdar://98592334

Added: 
    

Modified: 
    

Removed: 
    compiler-rt/test/asan/TestCases/Darwin/getpwnam.c


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Darwin/getpwnam.c b/compiler-rt/test/asan/TestCases/Darwin/getpwnam.c
deleted file mode 100644
index db3ec3f8c2a80..0000000000000
--- a/compiler-rt/test/asan/TestCases/Darwin/getpwnam.c
+++ /dev/null
@@ -1,15 +0,0 @@
-// RUN: %clang_asan %s -o %t
-// RUN: %run %t 2>&1 | FileCheck %s
-
-#include <pwd.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <sys/types.h>
-
-int main(int argc, const char * argv[]) {
-  getpwnam(NULL);
-  fprintf(stderr, "Finished.\n");
-  return 0;
-}
-
-// CHECK: Finished.


        


More information about the llvm-commits mailing list