[PATCH] D132755: [DWARFLinker][NFC] Set the target DWARF version explicitly.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D132755#3779145 <https://reviews.llvm.org/D132755#3779145>, @dblaikie wrote:

> Mixed feelings, but the indexing situation's somewhat motivational - though I think it'd be OK for it to be an error if you asked for DWARFv5 accelerator tables but the contents was producing DWARFv4 (or to have the request for DWARFv5 accelerator tables to up the version to DWARFv5 - though that wouldn't need a user-visible option to explicitly ask for DWARFv5)

The good thing about interface changes from this patch is that it allows implementing any strategy(since option is set explicitly). It may be done "OK for it to be an error if you asked for DWARFv5 accelerator tables but the contents was producing DWARFv4", or it could be done "request for DWARFv5 accelerator tables to up the version to DWARFv5", or "set Apple for DWARFv4, set DebugNames for DWARF5 ",  or anything else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132755/new/

https://reviews.llvm.org/D132755